New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selected checkbox fill color when checkbox group is disabled #5407
Conversation
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on chrome and iphone and wasn't able to find a case where it wasn't correct.
Build successful! 🎉 |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
Closes #5378
After investigating this a bit more, I don't think this is a css specificity issue. It seemed that when the
isDisabled
prop was provided to<CheckboxGroup>
, that value was not passed to the individual<Checkbox>
components, resulting in the absence of theis-disabled
class in their classnames. Therefore, if you wanted to the disabled styles to be applied to a selected checkbox in a checkbox group, you would also have to directly passisDisabled
to that specific checkbox.Looking back at the commit history, it appears that this "broke" with this PR (#3827). However, if you go commit before it (which is #3962), you'll notice that the styling might be correct, but the
is-disabled
class still isn't a part of the classname even though it should be.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: