Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix icon size issue with inherited box sizing #1058

Merged
merged 1 commit into from Sep 10, 2020

Conversation

deloreyj
Copy link
Contributor

@deloreyj deloreyj commented Sep 8, 2020

Closes #1042

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Render an Action Button with an icon on a page with this style rule applied. Verify the icon is sized correctly

* {
  box-sizing: inherit;
}

Since this is an edge case style-only code change, what type of test would y'all like?

🧢 Your Project:

Adobe - Magento

@devongovett devongovett merged commit b8e7a96 into adobe:main Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action Buttons displaying tiny icons
2 participants