Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AriaBreadcrumbItemProps interface public #1317

Merged
merged 4 commits into from Dec 3, 2020

Conversation

stefanprobst
Copy link
Contributor

Closes #1303

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably should've asked earlier, but what do you need this type for? I assume you are using the useBreadcrumbItem hook and need this for prop typing purposes?

LGTM, just curious.

@stefanprobst
Copy link
Contributor Author

I assume you are using the useBreadcrumbItem hook and need this for prop typing purposes

yes exactly - i mostly try to use the hook props as component props

@devongovett devongovett merged commit 703966e into adobe:main Dec 3, 2020
@stefanprobst stefanprobst deleted the types/breadcrumbitem branch December 4, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

types: Make AriaBreadcrumbItemProps interface public
4 participants