Fixing combobox menu flipping on initial open #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
LFDanLu
commented
Jun 29, 2021
Comment on lines
+140
to
+149
| // Update position once the ListBox has rendered. This ensures that | ||
| // it flips properly when it doesn't fit in the available space. | ||
| // TODO: add ResizeObserver to useOverlayPosition so we don't need this. | ||
| useLayoutEffect(() => { | ||
| if (state.isOpen) { | ||
| requestAnimationFrame(() => { | ||
| updatePosition(); | ||
| }); | ||
| } | ||
| }, [state.isOpen, updatePosition]); |
There was a problem hiding this comment.
Taken straight from Picker. I thought I remembered this bit of code causing problems in the past for ComboBox but I dug through the repo/pulls/issues and couldn't find anything. Seems to work fine in testing
|
Build successful! 🎉 |
snowystinger
approved these changes
Jun 29, 2021
|
LGTM |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
dannify
approved these changes
Jul 21, 2021
|
Build successful! 🎉 |
devongovett
approved these changes
Jul 21, 2021
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2024
✅ Pull Request Checklist:
📝 Test Instructions:
In any of the combobox stories, size your window in such a way that the listbox won't fit fully at the bottom. The listbox should be flipped to the top when opened
🧢 Your Project:
RSP