Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSRProvider appends to a string prefix to avoid ID collisions #2278

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

jfuchs
Copy link
Contributor

@jfuchs jfuchs commented Sep 3, 2021

SSRProvider appends to a string prefix to avoid ID collisions

Closes #2277

Putting this up as a draft to see if y'all are interested. If so, I'm happy to fix it up.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening this! I think this is the right solution. I had one suggestion, and you'll need to fix the linter errors and sign the CLA for us to merge it. 😄

packages/@react-aria/ssr/src/SSRProvider.tsx Show resolved Hide resolved
@jfuchs jfuchs closed this Sep 7, 2021
@jfuchs jfuchs reopened this Sep 7, 2021
@jfuchs jfuchs marked this pull request as ready for review September 7, 2021 17:35
@jfuchs
Copy link
Contributor Author

jfuchs commented Sep 7, 2021

Does this need a changeset? And if so, would you give this a minor version bump because of the potential for snapshot changes?

@devongovett
Copy link
Member

Thanks! Yes, we will release this as a minor. We will be doing some testing in the next few days and probably releasing early next week. We'll take care of the version bumps and release notes. In the meantime, you're welcome to use our nightly releases.

@devongovett devongovett merged commit 19db333 into adobe:main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested SSRProviders don't guarantee unique IDs
4 participants