Fixes #1666: Omit duplicated type in ColorFieldProps #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `onChange` prop of ValueBase type
kwoncharles
requested review from
dannify,
devongovett and
snowystinger
as code owners
devongovett
reviewed
Sep 5, 2021
| @@ -76,7 +76,7 @@ export interface Color { | |||
| formatChannelValue(channel: ColorChannel, locale: string): string | |||
| } | |||
|
|
|||
| export interface ColorFieldProps extends ValueBase<string | Color>, InputBase, Validation, FocusableProps, TextInputBase, LabelableProps { | |||
| export interface ColorFieldProps extends Omit<ValueBase<string | Color>, 'onChange'>, InputBase, Validation, FocusableProps, TextInputBase, LabelableProps { | |||
There was a problem hiding this comment.
Doesn't this get overridden below anyway? Do we need to explicitly omit it?
There was a problem hiding this comment.
@devongovett
You are right. However, when the --strict or --strictFunctionTypes option is enabled, Typescript complains about this as you can see in the issue.
It seems that the issue author's IDE is using the user-configured TS option rather than the one in react-spectrum/tsconfig.json.
If we don't need to consider it now, It's better to close it now :)
There was a problem hiding this comment.
Ah, in that case I'm fine with merging it.
devongovett
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1666
onChangeprop ofValueBase✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: