Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@react-aria/overlays): prevent exception on Cypress #2341

Merged
merged 7 commits into from Oct 28, 2021
Merged

fix(@react-aria/overlays): prevent exception on Cypress #2341

merged 7 commits into from Oct 28, 2021

Commits on Sep 27, 2021

  1. fix(@react-aria/overlays): prevent exception on Cypress 

    Cypress screenshot command triggers a scroll event where the event target is window, not a DOM element.

closes adobe#2340
    @alirezamirian
    alirezamirian committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    8be7d91 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 2340-overlays-cypress-issue

    @snowystinger
    snowystinger committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    a7abbdb View commit details
    Browse the repository at this point in the history

  3. test(@react-aria/overlays): add two test case for close on scroll 

    related to adobe#2340.

The first test case is related to the regression mentioned here: adobe#2341 (comment)

The second test case captures the fix for the cypress issue.
    @alirezamirian
    alirezamirian committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    c5f5266 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Merge branch 'main' into 2340-overlays-cypress-issue

    @snowystinger
    snowystinger committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    6e8d812 View commit details
    Browse the repository at this point in the history

  2. window scroll to behave same as document

    @snowystinger
    snowystinger committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    c246bed View commit details
    Browse the repository at this point in the history

  3. remove comment that no longer applies

    @snowystinger
    snowystinger committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    46d5f12 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Merge branch 'main' into 2340-overlays-cypress-issue

    @LFDanLu
    LFDanLu committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    e966664 View commit details
    Browse the repository at this point in the history