Add noValidate to Form by default #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
dkario
reviewed
Sep 30, 2021
| @@ -388,7 +390,7 @@ function FormWithSubmit() { | |||
| } else { | |||
| setFormStatus('progress'); | |||
| } | |||
| }, [policies, policiesDirty, pet, petDirty, truth, truthDirty, isSubmitted]); | |||
| }, [policies, policiesDirty, pet, petDirty, truth, truthDirty, isSubmitted, emailDirty]); | |||
There was a problem hiding this comment.
Should we also add email to the dep array? And put them before isSubmitted (nit)
|
Build successful! 🎉 |
LFDanLu
approved these changes
Sep 30, 2021
snowystinger
approved these changes
Sep 30, 2021
I think since this is Spectrum-only it's probably ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2401. If you use
type="email",pattern, etc. native form validation UI shows rather than spectrum's help text. This addsnoValidateto<Form>by default to avoid this.Question: do we need a way to override this? I can't think of a valid use case that wouldn't be better served by custom Spectrum validation.