Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add className to DOMAttributes interface #3409

Merged
merged 2 commits into from Aug 19, 2022
Merged

Add className to DOMAttributes interface #3409

merged 2 commits into from Aug 19, 2022

Conversation

reidbarber
Copy link
Member

Closes #3372

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@reidbarber reidbarber added the small review Easy to review PR label Aug 17, 2022
@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@reidbarber reidbarber merged commit 66283e2 into main Aug 19, 2022
@reidbarber reidbarber deleted the DOMAttributes-className branch August 19, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@snowystinger snowystinger snowystinger approved these changes

Assignees
No one assigned
Labels
small review Easy to review PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModalProviderProps type includes style but not className
4 participants
@reidbarber @adobe-bot @devongovett @snowystinger