Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableView cosmetic fixes from testing session #3560

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Sep 26, 2022

Closes
allows resizing, header cell button has a 2px focus ring around it, except the top is only 1px it looks like (RS)
allowsResizing, column divider is offset by .5px with resizer (DG)
focus ring width is shortened by width of resizer. looks esp weird with dividers (DG)
The divider sticks out a bit above the resizer nubbin. See screenshot row 6 (DL)

Also included List/Menu Section fix
Section Titles seem a bit too close to the divider with too much trailing whitespace? Note, this spacing didn't change, but perhaps is more noticeable with descenders? (RS)

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link

@snowystinger snowystinger mentioned this pull request Sep 27, 2022
5 tasks
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all fixes work as described.

@adobe-bot
Copy link

@snowystinger snowystinger merged commit 0810381 into main Sep 28, 2022
@snowystinger snowystinger deleted the testing-session-table-cosmetic-fixes branch September 28, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants