Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TreeCollection and TableCollection #3673

Conversation

jlongster-stripe
Copy link

Closes

✅ Pull Request Checklist:

This change shouldn't need any additional tests. We are building some utilities that want to access these collection classes. ListCollection is already exported (https://github.com/adobe/react-spectrum/blob/main/packages/%40react-stately/list/src/index.ts#L17) but these collection classes are not, so I'm assuming it'd be OK to export these.

  • [?] Included link to corresponding React Spectrum GitHub Issue.
  • [N/A] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [N/A] Filled out test instructions.
  • [N/A] Updated documentation (if it already exists for this component).
  • [N/A] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

N/A

🧢 Your Project:

Stripe :)

@devongovett
Copy link
Member

Seems reasonable, related to #3405. Curious what you're looking to do with them!

@snowystinger
Copy link
Member

If you don't mind, follow the instructions here https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement then close and reopen this PR, that will cause it to pass the last check so we can review this PR and consider merging it.

@reidbarber
Copy link
Member

Fixed in #3690 so we can include this in the next release.

@reidbarber reidbarber closed this Oct 27, 2022
@jlongster-stripe
Copy link
Author

Thanks a lot @reidbarber! I've been traveling so I didn't have time to re-open this.

@devongovett We are actually using our own collection APIs which have different tradeoffs. We aren't using the static JSX approach which turns it into data. Happy to talk more about it if you want!

@devongovett
Copy link
Member

That's interesting. I have been working on a potential new approach as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants