Revert ESM #3839
Merged
Revert ESM #3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
approved these changes
Dec 13, 2022
This was referenced Dec 13, 2022
Merged
dannify
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #3630. Unfortunately, it broke support for webpack 4, which still gets over 8 million downloads per week (over 2x more than webpack 5). This would be a huge breaking change.
The issue is that webpack 4 treats
.mjsfiles as "strict ESM", attempting to follow native Node behavior. This means any imports within.mjswill not be resolved using the"module"field in package.json. webpack 4 also does not support the"exports"field. Therefore, the CommonJS version will be loaded from the"main"field. But, it is also loaded in strict ESM mode, meaning__esModuleinterop is also disabled, leading to compilation errors. Some additional information can be found in webpack/webpack#7482.