New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add negative margin on VisuallyHidden on both sides #4177
Conversation
This will likely also close #4086 @majornista where'd these styles come from? https://github.com/adobe/react-spectrum/blame/30141c06b8630538cd1767c1e9e9d2fcdbac40f5/packages/%40react-aria/visually-hidden/src/VisuallyHidden.css#L19 (I know it says devon did it, but I traced it further back to you in our previous version) |
I checked my fix and the issue is still present 😞 It's working in react-aria 3.23.1 though 😄 |
|
@filipw01 Can you verify that my update to |
I don't think there's any difference in react between |
Closes #4176
✅ Pull Request Checklist:
📝 Test Instructions:
Open reproduction from the issue and change margin on VisuallyHidden component
🧢 Your Project:
ChiliPiper https://www.chilipiper.com/