Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative margin on VisuallyHidden on both sides #4177

Merged
merged 6 commits into from Mar 29, 2023

Conversation

filipw01
Copy link
Contributor

@filipw01 filipw01 commented Mar 8, 2023

Closes #4176

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Open reproduction from the issue and change margin on VisuallyHidden component

🧢 Your Project:

ChiliPiper https://www.chilipiper.com/

@snowystinger
Copy link
Member

This will likely also close #4086

@majornista where'd these styles come from? https://github.com/adobe/react-spectrum/blame/30141c06b8630538cd1767c1e9e9d2fcdbac40f5/packages/%40react-aria/visually-hidden/src/VisuallyHidden.css#L19 (I know it says devon did it, but I traced it further back to you in our previous version)

@filipw01
Copy link
Contributor Author

filipw01 commented Mar 9, 2023

This will likely also close #4086

I checked my fix and the issue is still present 😞 It's working in react-aria 3.23.1 though 😄

@majornista
Copy link
Collaborator

@majornista
Copy link
Collaborator

@filipw01 Can you verify that my update to VisuallyHidden resolves the issue for you?

@filipw01
Copy link
Contributor Author

@filipw01 Can you verify that my update to VisuallyHidden resolves the issue for you?

I don't think there's any difference in react between 1 and '1px'. So yes, it still works 😄

@devongovett devongovett merged commit 615bcfc into adobe:main Mar 29, 2023
2 checks passed
@filipw01 filipw01 deleted the visually-hidden-fix branch March 29, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VisuallyHidden triggering overflow in Chrome
4 participants