Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Table resize observer warning in React 16/17 #5367

Closed
wants to merge 5 commits into from

Conversation

snowystinger
Copy link
Member

Closes #1924
It's easier to test in Safari where you don't need to add the console log specified in the issue comment.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Issue says to resize the window, but it's easier to resize the iframe by making the storybook left rail wider.

🧢 Your Project:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useResizeObserver not preventing Resize Observer errors in some situations
1 participant