Add directory support for FileTrigger #5444
Conversation
| multiple={allowsMultiple} /> | ||
| multiple={allowsMultiple} | ||
| // @ts-expect-error | ||
| webkitdirectory={UNSAFE_directory ? '' : undefined} /> |
There was a problem hiding this comment.
this implementation uses an empty string for the webkitdirectory attribute instead of a boolean value because it does not function correctly with boolean.
| @@ -120,6 +120,20 @@ A file trigger can accept multiple files by passsing the `allowsMultiple` proper | |||
| </FileTrigger> | |||
| ``` | |||
|
|
|||
| ## Directory Selection | |||
|
|
|||
| To enable selecting directories instead of files, use the `UNSAFE_directory` property. | |||
There was a problem hiding this comment.
Since it looks like this is well-supported with browsers we support, I think we can just use directory.
There was a problem hiding this comment.
Fixed by the following commit.
|
|
||
| To enable selecting directories instead of files, use the `UNSAFE_directory` property. | ||
|
|
||
| This reflects the webkitdirectory HTML attribute and allows users to select directories and their contents. |
There was a problem hiding this comment.
Feel free to make webkitdirectory link to https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory
There was a problem hiding this comment.
Thanks for the comment. Link added.
refac: Remove unsafe prefix
|
GET_BUILD |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'any' } |
Updated section title to match formatting of others
Closes #4963
✅ Pull Request Checklist:
📝 Test Instructions:
Verified that only directories are selected when the UNSAFE_directory property is applied.
Added test to verify that the webkitdirectory property is applied.
🧢 Your Project: