Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DismissButton has a height so it works with iOS VO #5539

Merged
merged 1 commit into from Dec 7, 2023

Conversation

devongovett
Copy link
Member

Noticed that the dismiss button in popovers was not working on iOS VO on the new homepage. Looks like it was caused by Tailwind's CSS reset which removes the default padding from buttons. That caused it to be zero width/height, which iOS VO will ignore. This adds an inline width and height property to ensure it is always set. Should not affect anything because it's inside a VisuallyHidden already.

@rspbot
Copy link

rspbot commented Dec 6, 2023

@rspbot
Copy link

rspbot commented Dec 6, 2023

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@devongovett devongovett merged commit c465f95 into main Dec 7, 2023
26 checks passed
@devongovett devongovett deleted the dismiss-button-height branch December 7, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants