Make value and defaultValue valid in number and slider fields #5543
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| ${'defaultValue maxValue step'} | ${{defaultValue: 20, maxValue: 10, step: 3}} | ${'9'} | ||
| ${'value minValue'} | ${{value: 20, minValue: 50}} | ${'50'} | ||
| ${'value maxValue'} | ${{value: 20, maxValue: 10}} | ${'10'} | ||
| ${'value minValue step'} | ${{value: 20, minValue: 50, step: 3}} | ${'50'} |
There was a problem hiding this comment.
I've forgotten why this doesn't clamp to 51. Is it that the step interval start at zero or min?
There was a problem hiding this comment.
steps start at the minValue
If RAC has it, we're fine, also we have tests for this now |
| if (!isNaN(value)) { | ||
| if (!isNaN(step)) { | ||
| value = snapValueToStep(value, minValue, maxValue, step); | ||
| } else { | ||
| value = clamp(value, minValue, maxValue); | ||
| } | ||
| } |
There was a problem hiding this comment.
so this is a departure from native behavior where the initial value provided to the input is respected even if it doesn't match the step but I saw in the spec where it recommends this new behavior so I'm fine with this, feels better anyways
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'any' } |
Closes #4978
Closes #5556
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: