-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate menutrigger state #5597
Conversation
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } @react-stately/comboboxComboBoxState ComboBoxState<T> {
commit: () => void
+ focusStrategy: FocusStrategy
inputValue: string
open: (FocusStrategy | null, MenuTriggerAction) => void
revert: () => void
setInputValue: (string) => void
}
it changed:
@react-stately/menuUNSTABLE_useSubmenuTriggerState UNSTABLE_useSubmenuTriggerState {
props: SubmenuTriggerProps
- state: MenuTriggerState
+ state: RootMenuTriggerState
returnVal: undefined
} MenuTriggerState MenuTriggerState {
- UNSTABLE_closeSubmenu: (Key, number) => void
- UNSTABLE_expandedKeysStack: Array<Key>
- UNSTABLE_openSubmenu: (Key, number) => void
- close: () => void
focusStrategy: FocusStrategy
open: (FocusStrategy | null) => void
toggle: (FocusStrategy | null) => void
} it changed:
RootMenuTriggerState-
+RootMenuTriggerState {
+ UNSTABLE_closeSubmenu: (Key, number) => void
+ UNSTABLE_expandedKeysStack: Array<Key>
+ UNSTABLE_openSubmenu: (Key, number) => void
+ close: () => void
+ focusStrategy: FocusStrategy
+ open: (FocusStrategy | null) => void
+ toggle: (FocusStrategy | null) => void
+} it changed:
@react-stately/selectSelectState SelectState<T> {
+ focusStrategy: FocusStrategy
isFocused: boolean
+ open: (FocusStrategy | null) => void
setFocused: (boolean) => void
+ toggle: (FocusStrategy | null) => void
} it changed:
|
Closes
Open to better names
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: