add allowsEmptyCollection property to ComboBoxProps interface #5842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #5690
It is already possible to provide allowsEmptyCollection as a prop to Combobox, but TypeScript will not be happy since its untyped.
✅ Pull Request Checklist:
📝 Test Instructions:
Start storybook
Add allowsEmptyCollection={true} to e.g. ComboBoxAsyncLoadingExample story
Type in foo
Add 'f'
Remove 'f' and see that the menu remains open
If you set allowsEmptyCollection={false} or simply remove the prop you can see that when you remove 'f' that the menu will remain closed.