Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and export defaultSlot and remove slotCallbackSymbol from RAC #5850

Merged
merged 12 commits into from
Feb 14, 2024
Merged

Rename and export defaultSlot and remove slotCallbackSymbol from RAC #5850

merged 12 commits into from
Feb 14, 2024

Conversation

alexasselin008
Copy link
Contributor

@alexasselin008 alexasselin008 commented Feb 9, 2024

Closes #5671

Of course, the hardest part of this PR was the documentation, so feel free to suggest any changes, and I'll happily make them.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@alexasselin008 alexasselin008 changed the title Rename and export defaultSlot from RAC Rename and export defaultSlot and remove slotCallbackSymbol from RAC Feb 9, 2024
@snowystinger
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented Feb 12, 2024

snowystinger
snowystinger previously approved these changes Feb 12, 2024
@LFDanLu
Copy link
Member

LFDanLu commented Feb 12, 2024

GET_BUILD

@rspbot
Copy link

rspbot commented Feb 12, 2024

@rspbot
Copy link

rspbot commented Feb 12, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

snowystinger
snowystinger previously approved these changes Feb 12, 2024
Co-authored-by: Daniel Lu <danilu@adobe.com>
@LFDanLu
Copy link
Member

LFDanLu commented Feb 13, 2024

@alexasselin008 looks like a flakey ci build, rerunning

EDIT: holding off the merge for this release, will go in right after though!

@reidbarber reidbarber merged commit 5afad49 into adobe:main Feb 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export defaultSlot in RAC or a way to workaround required slot errors
5 participants