-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and export defaultSlot
and remove slotCallbackSymbol
from RAC
#5850
Conversation
defaultSlot
from RAC defaultSlot
and remove slotCallbackSymbol
from RAC
GET_BUILD |
Build successful! 🎉 |
GET_BUILD |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
Co-authored-by: Daniel Lu <danilu@adobe.com>
@alexasselin008 looks like a flakey ci build, rerunning EDIT: holding off the merge for this release, will go in right after though! |
Closes #5671
defaultSlot
toDEFAULT_SLOT
to follow the naming convention used by other exported symbols.DEFAULT_SLOT
fromreact-aria-components
.slotCallback
symbol as suggested by @devongovett in this comment: ExportdefaultSlot
in RAC or a way to workaround required slot errors #5671 (comment).defaultSlot
in RAC or a way to workaround required slot errors #5671 (comment).Of course, the hardest part of this PR was the documentation, so feel free to suggest any changes, and I'll happily make them.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: