Support onAction and isDisabled on item elements #5874
Conversation
|
Build successful! 🎉 |
There was a problem hiding this comment.
move from state.disabledKeys to state.selectionManager is a bit unfortunate if anyone has written their own work on top of collections, but probably not very common and we can mention it in release notes
I forget, have we also discussed isSelected already as well?
|
yeah it shouldn't break because disabledKeys is still there, but just won't support the new feature until migrating. what about isSelected? |
did we want to support the same kind of thing? is that possible? I have a vague feeling it wasn't possible, but can't recall why |
|
you mean isSelected on individual items? I think that's not possible because multiple items can be selected at once, so onSelectionChange really needs to be on the root level. Makes sense to keep selectedKeys at the same level. |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'any' } @react-aria/gridGridKeyboardDelegateOptions GridKeyboardDelegateOptions<C, T> {
collator?: Intl.Collator
collection: C
direction: Direction
+ disabledBehavior?: DisabledBehavior
disabledKeys: Set<Key>
focusMode?: 'row' | 'cell'
layout?: Layout<Node<T>>
ref?: RefObject<HTMLElement>
it changed:
|
Relates to #5058 #5459
This adds support for the
onActionandisDisabledprops directly on collection items in addition to the existing collection-levelonActionanddisabledKeys. In some cases it can be easier to set these props at an item level, for example with static collections (e.g. common in menus). If both are provided, an item is disabled if either theisDisabledprop is set or its key is indisabledKeys, and bothonActionhandlers are called.Note that while this is implemented in the hooks, these props are only in the TS definitions for RAC and not RSP (or the older stately collections). Since RSP uses a single
<Item>component across all components, we can't easily add props to some components but not others. In RAC we separated these out into separate components so this is possible.