Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hrefLang attribute to Link #5894

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

ryo-manba
Copy link
Contributor

@ryo-manba ryo-manba commented Feb 16, 2024

Closes #5633

As I mentioned in my comment below, I'm undecided about supporting the title attribute.
I would like to hear your thoughts on this.
#5633 (comment)

βœ… Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

πŸ“ Test Instructions:

  1. Visit http://localhost:9003/?path=/story/react-aria-components--link-example&providerSwitcher-express=false&strict=true
  2. Check that the hrefLang attribute is specified.

🧒 Your Project:

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll bring up title with the team. It can always come in later if necessary.

@reidbarber reidbarber merged commit 8b7fb3e into adobe:main Feb 17, 2024
26 checks passed
@ryo-manba ryo-manba deleted the feat/link-hreflang-attribute branch February 17, 2024 01:50
@ryo-manba ryo-manba restored the feat/link-hreflang-attribute branch February 17, 2024 01:50
@ryo-manba ryo-manba deleted the feat/link-hreflang-attribute branch February 17, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Link component is missing props for lang, hrefLang and title
3 participants