Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null type to Radiogroup value prop. #5896

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

sookmax
Copy link
Contributor

@sookmax sookmax commented Feb 16, 2024

Closes #5871

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Story

Controlled RadioGroup

http://localhost:9003/?path=/story/react-aria-components--radio-group-controlled-example&providerSwitcher-express=false&strict=true

🧢 Your Project:

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sookmax
Copy link
Contributor Author

sookmax commented Feb 20, 2024

@LFDanLu Hi, I have a question that's unrelated to this PR.

does every PR deploy the associated storybook somewhere? I think I saw some long domain names that include microsoft or windows somewhere in other people's PRs.. that looked like a storybook instance.. but I'm not sure 😅.

The reason why I ask this is that I thought it would be nicer to share the deployed storybook for a PR (if exists) than using localhost:9003 😭.

@LFDanLu
Copy link
Member

LFDanLu commented Feb 20, 2024

@sookmax For contributor PRs we don't automatically run the storybook build for security reasons hence why you might notice the occasional comment from a team member of "GET_BUILD" that triggers it manually.

@rspbot
Copy link

rspbot commented Feb 20, 2024

@rspbot
Copy link

rspbot commented Feb 20, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@LFDanLu LFDanLu merged commit bf7071f into adobe:main Feb 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript: RadioGroupProps['value'] does not allow null
5 participants