-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix focus tracking for dynamic iframe content #5922
Conversation
GET_BUILD |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, if you have some time, a unit test would be good too, to make sure we don't have regressions. the story is helpful, thanks for including that
reminder for anyone looking at this. first click into an iframe will result in focus visible, this is expected. click a second time and it'll go away
…/react-spectrum into ritesh/focus-ring-iframe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the test started. It appears there was an issue with jsdom tab/focus. I found a way to work around it.
Closes #5882
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: