-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readonly & required data attributes to <TextField />
#5964
Add readonly & required data attributes to <TextField />
#5964
Conversation
GET_BUILD |
thanks! should we add these to NumberField/DateField/Select as well? |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem like they should be renderProps for the Input as well. Thoughts?
If we want to do that, it can be in a separate PR
@snowystinger Not sure if react-spectrum/packages/react-aria-components/test/TextField.test.js Lines 137 to 142 in 3492443
Title of which, by the way, doesn't seem to match what it is testing? |
Closes #5930
✅ Pull Request Checklist:
📝 Test Instructions:
Docs
http://localhost:1234/react-aria/TextField.html#textfield-2
🧢 Your Project: