Allow passing of inputRef to RAC Checkbox/Switch #5967
Conversation
yihuiliao
changed the title
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
|
||
| /** | ||
| * Merges multiple refs into one. Works with either callback or object refs. | ||
| */ | ||
| export function mergeRefs<T>(...refs: ForwardedRef<T>[]): ForwardedRef<T> { | ||
| export function mergeRefs<T>(...refs: Array<ForwardedRef<T> | MutableRefObject<T>>): ForwardedRef<T> { |
There was a problem hiding this comment.
had to update the typing for this but not super sure about this change
There was a problem hiding this comment.
react-aria/utils is in TS strict, so we're pretty well protected here
that said, I think it's the right change
|
|
||
| /** | ||
| * Merges multiple refs into one. Works with either callback or object refs. | ||
| */ | ||
| export function mergeRefs<T>(...refs: ForwardedRef<T>[]): ForwardedRef<T> { | ||
| export function mergeRefs<T>(...refs: Array<ForwardedRef<T> | MutableRefObject<T>>): ForwardedRef<T> { |
There was a problem hiding this comment.
react-aria/utils is in TS strict, so we're pretty well protected here
that said, I think it's the right change
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'any' } @react-aria/utilsmergeRefs mergeRefs<T> {
- refs: Array<ForwardedRef<T>>
+ refs: Array<ForwardedRef<T> | MutableRefObject<T>>
returnVal: undefined
} |
Opening to start a discussion about how we would like to handle inputRef since we ran into some issues with 🌈 Checkbox/Switch.
In RAC, inputRef is constructed within the component so that in our 🌈 implementation of Checkbox/Switch we have no way of passing an inputRef down to the input. We can't use
Contextbecause Checkbox/Switch don't use our<Input>component.If this is something we want, I can make adjustments to the ref support PR in 🌈 .
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: