-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use range calendar with mobile scrolling #5976
Fix use range calendar with mobile scrolling #5976
Conversation
GET_BUILD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally on my Android test device, behavior looks good to me. Thanks for splitting this out into this smaller change, will get it into another testing session soon!
Build successful! 🎉 |
In case you missed it. The only relevant change is deleting the line: I'm not sure why |
yep, it came from this commit: 6d84224. I couldn't figure out what flow specifically that line was fixing in the touch scroll/press drag range selection case, those flows seemed to still work on my own phone for the most part. We'll do more cross device testing in the upcoming testing session, will keep you posted on any findings there |
I just wanted to let you know that the team will be slow to review as we address some other priorities at the moment. We appreciate your understanding and apologize for the wait. |
I see. Thanks for your information. |
GET_BUILD |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
Closes #5975
✅ Pull Request Checklist:
📝 Test Instructions:
You can test it on an existing story:
Screen.Recording.2024-03-01.at.1.23.08.AM.mov
🧢 Your Project: