Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use range calendar with mobile scrolling #5976

Merged

Conversation

QzCurious
Copy link
Contributor

@QzCurious QzCurious commented Feb 29, 2024

Closes #5975

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

You can test it on an existing story:

Screen.Recording.2024-03-01.at.1.23.08.AM.mov

🧢 Your Project:

@LFDanLu
Copy link
Member

LFDanLu commented Mar 1, 2024

GET_BUILD

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally on my Android test device, behavior looks good to me. Thanks for splitting this out into this smaller change, will get it into another testing session soon!

@rspbot
Copy link

rspbot commented Mar 1, 2024

@QzCurious
Copy link
Contributor Author

QzCurious commented Mar 2, 2024

In case you missed it. The only relevant change is deleting the line:

8a7aec3
image

I'm not sure why 'pointercancal' were concerned back than. Perhaps you might want to double-check the purpose again.

@LFDanLu
Copy link
Member

LFDanLu commented Mar 4, 2024

yep, it came from this commit: 6d84224. I couldn't figure out what flow specifically that line was fixing in the touch scroll/press drag range selection case, those flows seemed to still work on my own phone for the most part. We'll do more cross device testing in the upcoming testing session, will keep you posted on any findings there

@yihuiliao
Copy link
Member

yihuiliao commented Mar 20, 2024

I just wanted to let you know that the team will be slow to review as we address some other priorities at the moment. We appreciate your understanding and apologize for the wait.

@QzCurious
Copy link
Contributor Author

I see. Thanks for your information.

@LFDanLu
Copy link
Member

LFDanLu commented Apr 1, 2024

GET_BUILD

@rspbot
Copy link

rspbot commented Apr 2, 2024

@rspbot
Copy link

rspbot commented Apr 2, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@LFDanLu LFDanLu merged commit 12f2f4e into adobe:main Apr 5, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[useRangeCalendar] Should allow (mobile) scroll through multiple calendars and then finalize a range selection
5 participants