fix validations for controlled datefield components

[tomekancu]

Closes #5963

✅ Pull Request Checklist:

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (for new code or code which already has tests).
• Filled out test instructions.
• Updated documentation (if it already exists for this component).
• Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

• open story
  http://localhost:9003/?path=/story/react-aria-components--date-field-example&args=minValue:1735686000000;validationBehavior:aria&providerSwitcher-express=false&strict=true
• switch isInvalid prop should disable aria error

🧢 Your Project:

[LFDanLu]

GET_BUILD

[rspbot]

Build successful! 🎉

• View the storybook
• View the storybook-17
• View the storybook-16
• View the documentation

[LFDanLu]

Just some small nit picks, but otherwise looks good to me, verified locally that a controlled isInvalid = false makes the FieldError no longer display errors in real time

[snowystinger]

GET_BUILD

[rspbot]

Build successful! 🎉

• View the storybook
• View the storybook-17
• View the storybook-16
• View the documentation

[snowystinger]

I'm trying to determine with the controls added (thanks by the way) if changing between false and true should bring up the errorMessage again. it currently doesn't even if the error message showed before I put isInvalid into a controlled state

1. set isInvalid to controlled state false
2. enter a min-date
3. set datefield to less than that
4. put isInvalid into controlled state true

[tomekancu]

@snowystinger that's exactly what this change does and what is expected in #5963.

Passing a controlled(true, false) value to isInvalid overrides the internal date field validation and prevents showing min/max errors.
If you want it back, you should pass undefined to isInvalid as an uncontrolled value.

[LFDanLu]

LGTM, thanks!

[devongovett]

Suggested change

	// If the isInvalid prop is true, update validation result in realtime (controlled).
	// If the isInvalid prop is controlled, update validation result in realtime.

[tomekancu]

done

[yihuiliao]

I just wanted to let you know that the team might be slow to review as we address some other priorities. We appreciate your understanding and apologize for the wait.

[LFDanLu]

GET_BUILD

[rspbot]

Build successful! 🎉

• View the storybook
• View the storybook-17
• View the storybook-16
• View the documentation

[rspbot]

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }