Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to add 'all' to expandedKeys and other tree followups #6002

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Mar 5, 2024

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Mar 5, 2024

@LFDanLu LFDanLu marked this pull request as ready for review March 18, 2024 16:37
@LFDanLu LFDanLu changed the title (WIP) Revert change to add 'all' to expandedKeys and other tree followups Revert change to add 'all' to expandedKeys and other tree followups Mar 18, 2024
@rspbot
Copy link

rspbot commented Mar 18, 2024

@rspbot
Copy link

rspbot commented Apr 5, 2024

@rspbot
Copy link

rspbot commented Apr 8, 2024

@rspbot
Copy link

rspbot commented Apr 8, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@react-stately/tree

TreeState

 TreeState<T> {
   collection: Collection<Node<T>>
   disabledKeys: Set<Key>
-  expandedKeys: 'all' | Set<Key>
+  expandedKeys: Set<Key>
   selectionManager: SelectionManager
-  setExpandedKeys: ('all' | Set<Key>) => void
+  setExpandedKeys: (Set<Key>) => void
   toggleKey: (Key) => void
 }

it changed:

  • useTreeState

TreeCollection

 TreeCollection<T> {
   at: (number) => void
   constructor: (Iterable<Node<T>>, {
-    expandedKeys?: 'all' | Set<Key>
+    expandedKeys?: Set<Key>
 }) => void
   getFirstKey: () => void
   getItem: (Key) => void
   getKeyAfter: (Key) => void
   getKeys: () => void
   getLastKey: () => void
   size: any
   undefined: () => void
 }
 

@LFDanLu LFDanLu merged commit 68af923 into main Apr 8, 2024
25 checks passed
@LFDanLu LFDanLu deleted the tree_followups branch April 8, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants