Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAC: Add validationBehavior to Form #6062

Merged
merged 9 commits into from
Apr 2, 2024
Merged

RAC: Add validationBehavior to Form #6062

merged 9 commits into from
Apr 2, 2024

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Mar 15, 2024

Adds validationBehavior prop to RAC Form, which can propagate to child form elements via context. An individual form component's validationBehavior provided via prop will get precedence over the Form's.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Mar 15, 2024

@adobe adobe deleted a comment from rspbot Mar 15, 2024
@rspbot
Copy link

rspbot commented Mar 18, 2024

@reidbarber reidbarber marked this pull request as ready for review March 18, 2024 17:38
@rspbot
Copy link

rspbot commented Mar 18, 2024

@adobe adobe deleted a comment from rspbot Mar 18, 2024
yihuiliao
yihuiliao previously approved these changes Mar 28, 2024
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks sound to me, mind adding a cursory test though to make sure the context is propagated properly?

@rspbot
Copy link

rspbot commented Apr 2, 2024

@adobe adobe deleted a comment from rspbot Apr 2, 2024
@rspbot
Copy link

rspbot commented Apr 2, 2024

@rspbot
Copy link

rspbot commented Apr 2, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@reidbarber reidbarber merged commit 94a1176 into main Apr 2, 2024
27 checks passed
@reidbarber reidbarber deleted the rac-form-validation branch April 2, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants