-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct floating precision in snapValueToStep #6113
fix: correct floating precision in snapValueToStep #6113
Conversation
GET_BUILD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and verified the issue of improper snapping at the min/max mentioned in the issue no longer happens. Mind adding a test for the failing case you found previously to https://github.com/adobe/react-spectrum/blob/main/packages/%40react-spectrum/numberfield/test/NumberField.test.js?
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
Closes Issue#6112
✅ Pull Request Checklist:
📝 Test Instructions:
Test with the same steps in the issue above