-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow ReactNode as children/content of the Toast - closes #6038 #6114
base: main
Are you sure you want to change the base?
feat: Allow ReactNode as children/content of the Toast - closes #6038 #6114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Question to the team. Do we actually want to allow ReactNode? or should we only allow strings and then parse the strings for b/i/etc and render that ourselves?
Previous concerns were that we didn't want to allow other interactive elements inside a toast. Nor things like images/spinners/etc.
If the team decides for text parse, is it okay to use additional property in options (like |
I was thinking very simple. IE, only allow bold. |
I guess that would be good to include also a |
We should be talking about this later this week. However, you brought up an important point. Which is that this is useful for non-spectrum users. We intend to make a RAC toast implementation which should alleviate this particular use case. |
Closes #6038
✅ Pull Request Checklist:
📝 Test Instructions:
yarn jest