-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#6130): Ignore HiddenSelect when tree walking #6139
fix(#6130): Ignore HiddenSelect when tree walking #6139
Conversation
We should skip HiddenSelect element in Picker when tree walking to determine the next or previous focusable element. However, we should not use [data-a11y-ignore], which is used to exclude elements from aXe automated accessibility tests.
e659367
to
b783832
Compare
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happier with this. I also feel like data-hidden
might be a more common than 0 chance, so I'm happier with the longer name for it as well. I think we can still change the name down the line as well, but at least now it's separated from tooling
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
what is the actual solution of this problem i am facing issue with Input, combobox inside table i am using react-aria-components |
@ashfaque-pixelotech Are you running into issues with keyboard navigation and combobox inside the table? |
We should skip HiddenSelect element in Picker when tree walking to determine the next or previous focusable element. However, we should not use [data-a11y-ignore], which is used to exclude elements from aXe automated accessibility tests.
Per comments: #6116 (comment)
Closes #6130
✅ Pull Request Checklist:
📝 Test Instructions:
Related Issue and PR: #5877, #5878, #6116
🧢 Your Project:
Adobe/Accessibility