Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove italics from ComboBox and SearchAutocomplete #6190

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Remove italics from ComboBox and SearchAutocomplete #6190

merged 2 commits into from
Apr 11, 2024

Conversation

yihuiliao
Copy link
Member

Removes the italics font when it says "Loading..." in ComboBox and "No results" in SearchAutocomplete

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@yihuiliao
Copy link
Member Author

I left the italics for StatusLight when variant="neutral" since it seems like it's in the designs but if want to remove that as well I'm happy to update this PR

@rspbot
Copy link

rspbot commented Apr 11, 2024

@rspbot
Copy link

rspbot commented Apr 11, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for including the new story

@yihuiliao yihuiliao marked this pull request as ready for review April 11, 2024 22:12
@yihuiliao yihuiliao merged commit ab4dd5a into main Apr 11, 2024
25 checks passed
@yihuiliao yihuiliao deleted the italics branch April 11, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants