Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@majornista pointed out that yellow
#ffff00
is described as "very light vibrant yellow green". I realized why this was the case: at lower lightness values, yellow tends to shift toward green. For example, both yellow (#ffff00
) and olive (#808000
) have the same hue, but olive appears more green. This is a similar effect to what happens between orange and brown. I've fixed this by adjusting the threshold for green to be a bit later, and added a lightness threshold for the green shift similar to what we have for orange/brown.Also added some additional tests based on CSS named color keywords.