Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various imports in the docs from being set to monopackage imports #6249

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Apr 23, 2024

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Apr 23, 2024

@rspbot
Copy link

rspbot commented Apr 23, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@@ -406,7 +405,7 @@ import {SubmenuTrigger} from '@react-spectrum/menu';

You can define a recursive function to render the nested menu items dynamically.

```tsx example
```tsx example keepIndividualImports
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we do this with jsdocs instead I wonder? then it'd be a little more obvious where updates need to happen
this also doesn't allow us to specify it on an individual import level, it's either all or nothing for the example

what if we could do

/**
 * @beta
 */
function SubmenuTrigger...

I guess the code to do the replacement is pretty simple, already has this flag, and there's only one instance of it, so probably not worth worry about

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially? I haven't entirely parsed through the MDXTransformer code but think that should be possible. I think another idea could be to expand the change I made to MDXTransformer here to accept an array of paths that we don't want transformed to be the mono package link.

@LFDanLu LFDanLu merged commit 4341a30 into main Apr 23, 2024
25 checks passed
@LFDanLu LFDanLu deleted the fix_links_in_docs branch April 23, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants