Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Submenu Tray experience for iOS VoiceOver #6263

Merged
merged 9 commits into from
Apr 27, 2024
Merged

Fix Submenu Tray experience for iOS VoiceOver #6263

merged 9 commits into from
Apr 27, 2024

Conversation

reidbarber
Copy link
Member

Due to the submenu tray animation, sometimes the parent menu would stay focused when the submenu opened on iOS when using VoiceOver. By focusing the first item after the animation completes, we can avoid this issue.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test submenu tray experience in iOS with VoiceOver.

🧢 Your Project:

RSP

@reidbarber reidbarber changed the title Fix Submenu Tray experience for iOS VoiceOver WIP: Fix Submenu Tray experience for iOS VoiceOver Apr 25, 2024
@rspbot
Copy link

rspbot commented Apr 26, 2024

@adobe adobe deleted a comment from rspbot Apr 26, 2024
@reidbarber reidbarber changed the title WIP: Fix Submenu Tray experience for iOS VoiceOver Fix Submenu Tray experience for iOS VoiceOver Apr 26, 2024
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit hacky 😜, but it seems to work pretty well in VO on my device.

@rspbot
Copy link

rspbot commented Apr 27, 2024

@rspbot
Copy link

rspbot commented Apr 27, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@dannify dannify merged commit b09a14e into main Apr 27, 2024
25 checks passed
@dannify dannify deleted the fix-tray-ios-vo branch April 27, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants