Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meter: add support for informative variant #6282

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Apr 29, 2024

This adds the "informative" option to variant, and makes it the default. This is in line with Spectrum guidelines. Previously, variant was required and "informative" was not an option.

This is just a non-breaking Typescript change, since the correct styles were already there.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check storybook and docs.

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Apr 29, 2024

@rspbot
Copy link

rspbot commented Apr 30, 2024

@rspbot
Copy link

rspbot commented Apr 30, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@react-spectrum/meter

Meter

 SpectrumMeterProps {
-  variant: 'positive' | 'warning' | 'critical'
+  variant?: 'informative' | 'positive' | 'warning' | 'critical' = 'informative'
 }

@reidbarber reidbarber merged commit e352bda into main Apr 30, 2024
25 checks passed
@reidbarber reidbarber deleted the meter-informative branch April 30, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants