Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export FormContext and document validationBehavior #6292

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Apr 30, 2024

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

https://reactspectrum.blob.core.windows.net/reactspectrum/46e2823cd67090f84a9379b6955254bbd55ade45/docs/react-aria/Form.html#validation-behavior

🧢 Your Project:

@rspbot
Copy link

rspbot commented Apr 30, 2024

@rspbot
Copy link

rspbot commented Apr 30, 2024

@rspbot
Copy link

rspbot commented Apr 30, 2024

Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first new example causes the page to flicker/reload on submit. None of the other examples on the page cause this flicker.

@reidbarber
Copy link
Member Author

@ktabors interesting, I'm not seeing that.

@rspbot
Copy link

rspbot commented Apr 30, 2024

@rspbot
Copy link

rspbot commented Apr 30, 2024

@rspbot
Copy link

rspbot commented Apr 30, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@reidbarber reidbarber merged commit 89f20b0 into main Apr 30, 2024
25 checks passed
@reidbarber reidbarber deleted the formcontext-docs branch April 30, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants