Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ref to useButton in useSelect example #871

Merged
merged 3 commits into from
Aug 1, 2020
Merged

Add missing ref to useButton in useSelect example #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3fd85a
Add missing ref to useButton in useSelect example
tristandubbeld Jul 31, 2020
88ebbcc
Fix key property on Section in collections doc
tristandubbeld Jul 31, 2020
7b26634
Merge branch 'main' into fix-issue-870
snowystinger Aug 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@react-aria/select/docs/useSelect.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ function Select(props) {
} = useSelect(props, state, ref);

// Get props for the button based on the trigger props from useSelect
let {buttonProps} = useButton(triggerProps);
let {buttonProps} = useButton(triggerProps, ref);

return (
<div style={{position: 'relative', display: 'inline-block'}}>
Expand Down
2 changes: 1 addition & 1 deletion packages/@react-stately/collections/docs/collections.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ let [sections, setSections] = useState([

<Picker items={sections}>
{section =>
<Section key={item.name} title={section.name} items={section.items}>
<Section key={section.name} title={section.name} items={section.items}>
{item => <Item key={item.name}>{item.name}</Item>}
</Section>
}
Expand Down