Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move isRequired from LabelableProps to SpectrumLabelableProps #877

Merged
merged 1 commit into from Aug 4, 2020
Merged

Move isRequired from LabelableProps to SpectrumLabelableProps #877

merged 1 commit into from Aug 4, 2020

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Aug 3, 2020 •
edited

Related to: #868 (comment)

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

@Andarist Andarist mentioned this pull request Aug 3, 2020
Merged
8 tasks
@devongovett devongovett merged commit b4089dd into adobe:main Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@dannify dannify Awaiting requested review from dannify

@snowystinger snowystinger Awaiting requested review from snowystinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Andarist @devongovett