-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding functions to create notes #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the comments with documentation links are not accurate, but this spans across the project and should be handled in a different PR.
@@ -85,3 +85,11 @@ export function updateDataElement(dataElementPatch) { | |||
data: dataElementPatch | |||
}); | |||
} | |||
|
|||
// Create a note for DataElement | |||
// https://developer.adobelaunch.com/api/data_elements/:data_element_id/notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for this API is located at: https://developer.adobelaunch.com/api/reference/1.0/notes/create/data_element/
@@ -83,3 +83,11 @@ export function reviseExtension(extensionId) { | |||
export function updateExtension(extensionId, extensionPatch) { | |||
return this.patch(`/extensions/${extensionId}`, extensionPatch); | |||
} | |||
|
|||
// Create a note for Extension | |||
// https://developer.adobelaunch.com/api/extensions/:extension_id/notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for this API is located at: https://developer.adobelaunch.com/api/reference/1.0/notes/create/extension/
@@ -279,3 +279,11 @@ export function updateLibrary(libraryPatch) { | |||
data: libraryPatch | |||
}); | |||
} | |||
|
|||
// Create a note for Library | |||
// https://developer.adobelaunch.com/api/libraries/:library_id/notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for this API is located at:
https://developer.adobelaunch.com/api/reference/1.0/notes/create/library/
@@ -33,3 +33,11 @@ export function updateProperty(propertyPatch) { | |||
export function deleteProperty(propertyId) { | |||
return this.delete(`/properties/${propertyId}`); | |||
} | |||
|
|||
// Create a note for Property | |||
// https://developer.adobelaunch.com/api/properties/:property_id/notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for this API is located at:
https://developer.adobelaunch.com/api/reference/1.0/notes/create/property/
@@ -63,3 +63,11 @@ export function updateRuleComponent(ruleComponentPatch) { | |||
data: ruleComponentPatch | |||
}); | |||
} | |||
|
|||
// Create a note for RuleComponent | |||
// https://developer.adobelaunch.com/api/rule_components/:rule_component_id/notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for this API is located at: https://developer.adobelaunch.com/api/reference/1.0/notes/create/rule_component/
@@ -80,3 +80,11 @@ export function updateRule(rulePatch) { | |||
data: rulePatch | |||
}); | |||
} | |||
|
|||
// Create a note for Rule | |||
// https://developer.adobelaunch.com/api/rules/:rule_id/notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for this API is located at: https://developer.adobelaunch.com/api/reference/1.0/notes/create/rule/
Description
Added functions to create notes on all possible components.
Related Issue
#59
Motivation and Context
There is no way to use the SDK to create notes on Launch components
How Has This Been Tested?
A separate project was used to create a Launch property with all components that can have a note added to them.
Screenshots (if appropriate):
Types of changes
Checklist: