Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding functions to create notes #60

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Adding functions to create notes #60

merged 2 commits into from
Dec 1, 2020

Conversation

Michael-Buser-SDI
Copy link
Contributor

@Michael-Buser-SDI Michael-Buser-SDI commented Nov 13, 2020

Description

Added functions to create notes on all possible components.

Related Issue

#59

Motivation and Context

There is no way to use the SDK to create notes on Launch components

How Has This Been Tested?

A separate project was used to create a Launch property with all components that can have a note added to them.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@thebenrob thebenrob added this to Incoming in Reactor Open Nov 13, 2020
@thebenrob thebenrob moved this from Incoming to In progress in Reactor Open Nov 13, 2020
@thebenrob thebenrob linked an issue Nov 13, 2020 that may be closed by this pull request
Copy link
Contributor

@gciltaru gciltaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments with documentation links are not accurate, but this spans across the project and should be handled in a different PR.

@@ -85,3 +85,11 @@ export function updateDataElement(dataElementPatch) {
data: dataElementPatch
});
}

// Create a note for DataElement
// https://developer.adobelaunch.com/api/data_elements/:data_element_id/notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -83,3 +83,11 @@ export function reviseExtension(extensionId) {
export function updateExtension(extensionId, extensionPatch) {
return this.patch(`/extensions/${extensionId}`, extensionPatch);
}

// Create a note for Extension
// https://developer.adobelaunch.com/api/extensions/:extension_id/notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -279,3 +279,11 @@ export function updateLibrary(libraryPatch) {
data: libraryPatch
});
}

// Create a note for Library
// https://developer.adobelaunch.com/api/libraries/:library_id/notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -33,3 +33,11 @@ export function updateProperty(propertyPatch) {
export function deleteProperty(propertyId) {
return this.delete(`/properties/${propertyId}`);
}

// Create a note for Property
// https://developer.adobelaunch.com/api/properties/:property_id/notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -63,3 +63,11 @@ export function updateRuleComponent(ruleComponentPatch) {
data: ruleComponentPatch
});
}

// Create a note for RuleComponent
// https://developer.adobelaunch.com/api/rule_components/:rule_component_id/notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -80,3 +80,11 @@ export function updateRule(rulePatch) {
data: rulePatch
});
}

// Create a note for Rule
// https://developer.adobelaunch.com/api/rules/:rule_id/notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for this API is located at: https://developer.adobelaunch.com/api/reference/1.0/notes/create/rule/

@gciltaru gciltaru merged commit 08710c5 into adobe:master Dec 1, 2020
Reactor Open automation moved this from In progress to Done Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Missing support to create notes
2 participants