Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDCL-6627: remove core extension check, look for isExternal === false. #130

Closed
wants to merge 1 commit into from

Conversation

brenthosie
Copy link
Member

Stop returning a settings object in creatSettingsFileTransformer. We are replacing in-place.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Stop returning a settings object in creatSettingsFileTransformer. We are replacing in-place.
@brenthosie brenthosie added this to Incoming in Reactor Open Sep 8, 2021
@brenthosie brenthosie moved this from Incoming to Waiting in Reactor Open Sep 8, 2021
@brenthosie brenthosie closed this Jun 16, 2022
@brenthosie brenthosie deleted the PDCL-6627-dynamic-host-finalize branch June 16, 2022 20:11
Reactor Open automation moved this from Waiting to Done Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant