Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getExtensionSettings to accept event as parameter #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PrateekTikku
Copy link

@PrateekTikku PrateekTikku commented Jan 11, 2023

Description

The function turbine.getExtensionSettings() can potentially be called from inside any condition/action exposed from an extension. Hence, the extension configuration should also be able to use the rule's synthetic event using %event%

Related Issue

#157

Motivation and Context

Passing the rule's synthetic event as parameter to turbine.getExtensionSettings() function call must be possible as this function internally calls replaceTokens() which replaces tokens with actual values. If in the extension configuration the user has used %event% as token, the turbine.getExtensionSettings() call from inside the action's/condition's module should be able to pass the event parameter it possess, so that the tokens are replaced with actual values coming from the event.

How Has This Been Tested?

Not tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The function turbine.getExtensionSettings() can potentially be called from inside any condition/action exposed from an extension. Hence, the extension configuration should be able to use the rule's synthetic event while replacing tokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant