Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDCL-9875: remove custom IE script to find turbine on the page when d… #160

Merged
merged 11 commits into from Feb 22, 2023

Conversation

brenthosie
Copy link
Member

…ynamicCDN is turned on.

Description

Related Issue

https://jira.corp.adobe.com/browse/PDCL-9875

Motivation and Context

possible xss risk when Adobe is hosting the library

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

dependabot bot and others added 5 commits November 14, 2022 23:23
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [engine.io](https://github.com/socketio/engine.io) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md)
- [Commits](socketio/engine.io@6.2.0...6.2.1)

---
updated-dependencies:
- dependency-name: engine.io
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](faisalman/ua-parser-js@0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@brenthosie
Copy link
Member Author

@jeffreywalter one thing to consider is any customer that has DynamiCDN turned on then their customers on IE would not be able to load our analytics anymore.

TODO: ensure that dynamic replacement "halts gracefully" with this change.

@jeffreywalter jeffreywalter added this to In progress in Reactor Open Feb 15, 2023
Brent Hosie and others added 6 commits February 21, 2023 17:34
…js-0.7.33

Bump ua-parser-js from 0.7.31 to 0.7.33
…-component-0.2.2

Bump decode-uri-component from 0.2.0 to 0.2.2
…6.2.1

Bump engine.io from 6.2.0 to 6.2.1
…ls-1.4.2

Bump loader-utils from 1.4.0 to 1.4.2
@brenthosie
Copy link
Member Author

@dompuiu putting this on next

@brenthosie brenthosie marked this pull request as ready for review February 22, 2023 18:08
@brenthosie brenthosie merged commit 4d90907 into master Feb 22, 2023
Reactor Open automation moved this from In progress to Done Feb 22, 2023
@brenthosie brenthosie deleted the PDCL-9875-deprecate-ie-findturbinescript branch February 22, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants