Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Need ModelObject constructor that takes schema content #52

Closed
shay-thompson opened this issue Oct 11, 2019 · 2 comments
Closed

Need ModelObject constructor that takes schema content #52

shay-thompson opened this issue Oct 11, 2019 · 2 comments

Comments

@shay-thompson
Copy link
Collaborator

shay-thompson commented Oct 11, 2019

This is a request for a version of this method, but which also accepts presetNodes and nodesToBuild

public ModelObject(String modelString, boolean useRequiredOnly)

Similar to this method, but the String is the actual content of the schema, not the path to the schema. We would like to be able to pre-download the schema from schemaregistry, and update it that way instead of using a locally stored version in resource folder.

public ModelObject(String resourceLocation, JSONObject presetNodes, Set nodesToBuild,
boolean useRequiredOnly)

Another option is to make the resource constructor more generic, and have it look at the actual String to see if its schema content or a path, and load accordingly? Its a bit tricky since they're both Strings so open to ideas or workarounds.

@gahag
Copy link
Contributor

gahag commented Oct 12, 2019

Can I work on this?

gahag added a commit to gahag/ride that referenced this issue Oct 12, 2019
gahag added a commit to gahag/ride that referenced this issue Oct 12, 2019
tedcasey pushed a commit that referenced this issue Oct 18, 2019
[Issue #52] Add schema content + presetNodes ModelObject constructor
@tedcasey
Copy link
Collaborator

tedcasey commented Nov 5, 2019

Fixed.

@tedcasey tedcasey closed this as completed Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants