Skip to content

Commit

Permalink
Drop node 10 support #87
Browse files Browse the repository at this point in the history
  • Loading branch information
alexkli committed Jan 27, 2023
1 parent b079994 commit 843cbf3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ jobs:
build:

runs-on: ubuntu-latest

permissions:
pull-requests: write

strategy:
matrix:
node-version: [10, 12, 14, 16, "lts/*"]
node-version: [12, 14, 16, "lts/*"]

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

language: node_js
node_js:
- "10"
- "12"
- "14"

Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ By default `sizewatcher` will

## Requirements

- [Nodejs](https://nodejs.org) version 10+
- [Nodejs](https://nodejs.org) version 12+ (since 1.3.0)
- recommended to use latest stable version "LTS"
- Github or Github Enterprise
- if you want to run it on pull requests
Expand Down Expand Up @@ -293,7 +293,7 @@ jobs:

For [Travis CI](https://travis-ci.org) you need to
- use `language: node_js`
- if you already use a different language, find a way to ensure Nodejs 10+ is installed
- if you already use a different language, find a way to ensure Nodejs 12+ is installed
- under `script` run `npx @adobe/sizewatcher`
- set a secret environment variable `GITHUB_TOKEN` in the [Travis repository settings](https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settings) with a github token with permission to comment on PRs and reporting commit statuses for the repository

Expand All @@ -313,7 +313,7 @@ script:
### CircleCI

For [CircleCI](https://circleci.com) you need to
- use a docker image with Nodejs 10+ installed
- use a docker image with Nodejs 12+ installed
- alternatively install [using nvm](https://www.google.com/search?q=circleci+use+nvm)
- run `npx @adobe/sizewatcher`
- set a secret environment variable `GITHUB_TOKEN` in the [CircleCI project settings](https://circleci.com/docs/2.0/env-vars/#setting-an-environment-variable-in-a-project) (or in a [Context](https://circleci.com/docs/2.0/env-vars/#setting-an-environment-variable-in-a-context)) with a github token with permission to comment on PRs and reporting commit statuses for the repository
Expand All @@ -338,7 +338,7 @@ jobs:

This is not tested well but might work.

Ensure Nodejs 10+ is installed.
Ensure Nodejs 12+ is installed.

Set these environment variables in the CI job:

Expand Down

0 comments on commit 843cbf3

Please sign in to comment.