-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding experiment function for rum bundler APIs #264
Conversation
This PR will trigger a minor release when merged. |
it('crunches experiment data', async () => { | ||
const experimentsResult = experiment.handler(bundles.rumBundles); | ||
console.log(JSON.stringify(experimentsResult)); | ||
// expect(expected404Result).to.eql(notfoundResult); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather not commit a test, or clearly mark it skipped, if it's not complete. don't want to give the false impression that this is actually tested down the road if we don't have any expectation yet 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
committed in hurry, during debug session with Ekrem. Fixed the tests properly now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff 👍
# [@adobe/spacecat-shared-rum-api-client-v2.1.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v2.0.3...@adobe/spacecat-shared-rum-api-client-v2.1.0) (2024-06-20) ### Features * adding experiment function for rum bundler APIs ([#264](#264)) ([b1a076d](b1a076d))
🎉 This PR is included in version @adobe/spacecat-shared-rum-api-client-v2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!