fix: #268 Import URL entities need a REDIRECT status, and additional properties for reporting #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properties for reporting
solaris007
approved these changes
Jun 18, 2024
adobe-bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
# [@adobe/spacecat-shared-data-access-v1.29.2](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.29.1...@adobe/spacecat-shared-data-access-v1.29.2) (2024-06-18) ### Bug Fixes * [#268](#268) Import URL entities need a REDIRECT status, and additional properties for reporting ([#269](#269)) ([88bb491](88bb491))
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v1.29.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
In order to support generating the import-report.xlsx file for an import job, we need the ability to track if a URL was skipped because it was a redirect, or if it failed for another reason.
Screenshot from an example import-report included below:
To support this, I'm proposing that we add the following properties to the import-url entities, in addition to the existing status:
An additional status REDIRECT will also be added to
ImportUrlStatusto facilitate generation of this report.