Skip to content

Commit

Permalink
chore: changeset, grammar
Browse files Browse the repository at this point in the history
  • Loading branch information
mdt2 committed May 14, 2024
1 parent 869857a commit 80be570
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
7 changes: 7 additions & 0 deletions .changeset/three-geese-relax.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@spectrum-css/popover": patch
---

fix(popover): correct left/right tips for RTL

Includes exposing Start and End tip placement variants in Storybook, and increased VRT coverage for Chromatic.
7 changes: 4 additions & 3 deletions components/popover/stories/popover.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ const ChromaticTipPlacementVariants = (args) => html`
if (option.startsWith("start") || option.startsWith("end"))
return "Changes side with text direction (like a logical property)";
if (option.startsWith("left") || option.startsWith("right"))
return "Text direction does not effect the position";
return "Text direction does not affect the position";
return null;
};
Expand All @@ -166,11 +166,12 @@ const ChromaticTipPlacementVariants = (args) => html`
content: [`${optionDescription()}`],
})}
`)}
</div>
</div>
<div style="padding-top: 2rem">
${SourcelessTemplate({
...args,
position: option,
isOpen: true,
})}
</div>
</div>
Expand All @@ -190,7 +191,7 @@ export const WithTip = (args) => html`
`;
WithTip.play = async ({ canvasElement }) => {
const canvas = within(canvasElement);
await userEvent.click(canvas.getByRole("button"));
window.isChromatic() ? null : await userEvent.click(canvas.getByRole("button"));
};
WithTip.args = {
withTip: true,
Expand Down

0 comments on commit 80be570

Please sign in to comment.